All hints

All files

Report generated by HLint v1.6.5 - a tool to suggest improvements to your Haskell code.

src\ByteStringUtils.hs:149:12: Warning: Redundant brackets
Found
(map (chr . fromIntegral)) `fmap` peekArray lout outbuf
Why not
map (chr . fromIntegral) `fmap` peekArray lout outbuf
src\ByteStringUtils.hs:180:1: Warning: Eta reduce
Found
fromForeignPtr fp s l = BI.PS fp s l
Why not
fromForeignPtr = BI.PS
src\ByteStringUtils.hs:186:1: Warning: Redundant brackets
Found
B.concat . (intersperse s)
Why not
B.concat . intersperse s
src\ByteStringUtils.hs:251:1: Warning: Use camelCase
Found
is_funky ps = ...
Why not
isFunky ps = ...
src\ByteStringUtils.hs:279:43: Error: Redundant do
Found
do hash (p `plusPtr` s) l
Why not
hash (p `plusPtr` s) l
src\ByteStringUtils.hs:286:25: Warning: Redundant brackets
Found
(fromIntegral x) + (rotateL h 8)
Why not
fromIntegral x + rotateL h 8
src\ByteStringUtils.hs:448:2: Error: Redundant $
Found
fail $ "problem in gzWriteToGzf"
Why not
fail "problem in gzWriteToGzf"
src\ByteStringUtils.hs:569:1: Warning: Use camelCase
Found
break_after_nth_newline 0 the_ps | ... = ...
Why not
breakAfterNthNewline 0 the_ps | ... = ...
src\ByteStringUtils.hs:590:1: Warning: Use camelCase
Found
break_before_nth_newline 0 the_ps | ... = ...
Why not
breakBeforeNthNewline 0 the_ps | ... = ...
src\CommandLine.hs:62:1: Warning: Redundant brackets
Found
(quotedArg ftable <|> unquotedArg ftable)
Why not
quotedArg ftable <|> unquotedArg ftable
src\CommandLine.hs:64:1: Warning: Use string literal
Found
[' ', '\t', '"', '%']
Why not
" \t\"%"
src\CommandLine.hs:64:1: Error: Redundant do
Found
do (try $ format ftable) <|> (many1 $ noneOf [' ', '\t', '"', '%'])
Why not
(try $ format ftable) <|> (many1 $ noneOf [' ', '\t', '"', '%'])
src\CommandLine.hs:64:1: Error: Redundant $
Found
(try $ format ftable) <|> (many1 $ noneOf [' ', '\t', '"', '%'])
Why not
(try $ format ftable) <|> many1 (noneOf [' ', '\t', '"', '%'])
src\CommandLine.hs:64:1: Error: Redundant $
Found
(try $ format ftable) <|> (many1 $ noneOf [' ', '\t', '"', '%'])
Why not
try (format ftable) <|> (many1 $ noneOf [' ', '\t', '"', '%'])
src\CommandLine.hs:67:1: Warning: Eta reduce
Found
quotedArg ftable
  = between (char '"') (char '"') $ quoteContent ftable
Why not
quotedArg = between (char '"') (char '"') . quoteContent
src\CommandLine.hs:69:29: Warning: Use string literal
Found
['"', '\\', '%']
Why not
"\"\\%"
src\CommandLine.hs:69:29: Warning: Redundant brackets
Found
escape <|> (try $ format ftable) <|>
  (many1 (noneOf ['"', '\\', '%']))
Why not
escape <|> (try $ format ftable) <|>
  many1 (noneOf ['"', '\\', '%'])
src\CommandLine.hs:69:29: Error: Redundant $
Found
escape <|> (try $ format ftable)
Why not
escape <|> try (format ftable)
src\CommandLine.hs:95:1: Error: Redundant do
Found
do skipMany1 space
Why not
skipMany1 space
src\CommandLine.hs:109:1: Warning: Eta reduce
Found
parseCmd ftable s = parse (commandline ftable) "" s
Why not
parseCmd ftable = parse (commandline ftable) ""
src\CommandLine.hs:112:1: Error: Use concatMap
Found
concat $ map escapeC s
Why not
concatMap escapeC s
src\CommandLine.hs:113:11: Error: Redundant $
Found
'%' : (intToHex $ ord x)
Why not
'%' : intToHex (ord x)
src\CommandLine.hs:121:1: Warning: Use ***
Found
\ (c, x) -> (toUpper c, urlEncode x)
Why not
toUpper *** urlEncode
src\CommandLine.hs:121:1: Warning: Redundant brackets
Found
ftable ++ (map (\ (c, x) -> (toUpper c, urlEncode x)) ftable)
Why not
ftable ++ map (\ (c, x) -> (toUpper c, urlEncode x)) ftable
src\darcs.hs:18:1: Error: Use better pragmas
Found
{-# OPTIONS_GHC -cpp  #-}
Why not






src\darcs.hs:23:1: Error: Use fewer imports

Found


import System.IO (hSetBinaryMode)
import System.IO (stdin, stdout)


Why not


import System.IO (hSetBinaryMode, stdin, stdout)







src\darcs.hs:61:1: Warning: Use head

Found


argv !! 0

Why not


head argv






src\darcs.hs:61:1: Warning: Use head

Found


argv !! 0

Why not


head argv






src\darcs.hs:61:1: Warning: Use head

Found


argv !! 0

Why not


head argv






src\darcs.hs:61:1: Warning: Use head

Found


argv !! 0

Why not


head argv






src\darcs.hs:61:1: Warning: Use head

Found


argv !! 0

Why not


head argv






src\darcs.hs:61:1: Warning: Use head

Found


argv !! 0

Why not


head argv






src\darcs.hs:61:1: Warning: Use head

Found


argv !! 0

Why not


head argv






src\darcs.hs:61:1: Error: Redundant $

Found


exitWith $ ExitSuccess

Why not


exitWith ExitSuccess






src\darcs.hs:61:1: Error: Redundant $

Found


exitWith $ ExitSuccess

Why not


exitWith ExitSuccess






src\darcs.hs:61:1: Error: Redundant $

Found


exitWith $ ExitSuccess

Why not


exitWith ExitSuccess






src\darcsman.hs:34:1: Warning: Use camelCase

Found


man_organizer commands = ...

Why not


manOrganizer commands = ...






src\darcsman.hs:52:1: Warning: Use camelCase

Found


man_helper cmds = ...

Why not


manHelper cmds = ...






src\darcsman.hs:55:9: Error: Redundant $

Found


putStrLn $ ".TP"

Why not


putStrLn ".TP"






src\darcsman.hs:66:1: Warning: Use camelCase

Found


man_trailer = ...

Why not


manTrailer = ...






src\darcsman.hs:77:1: Warning: Use camelCase

Found


man_header = ...

Why not


manHeader = ...






src\DateMatcher.hs:19:1: Error: Use better pragmas

Found


{-# OPTIONS_GHC -fglasgow-exts  #-}


Why not


{-# LANGUAGE ForeignFunctionInterface, UnliftedFFITypes, GADTs,
  ImplicitParams, ScopedTypeVariables, UnboxedTuples,
  TypeSynonymInstances, StandaloneDeriving, DeriveDataTypeable,
  FlexibleContexts, FlexibleInstances, ConstrainedClassMethods,
  MultiParamTypeClasses, FunctionalDependencies, MagicHash,
  PolymorphicComponents, UnicodeSyntax, PostfixOperators,
  PatternGuards, LiberalTypeSynonyms, RankNTypes, ImpredicativeTypes,
  TypeOperators, RecursiveDo, ParallelListComp, EmptyDataDecls,
  KindSignatures, GeneralizedNewtypeDeriving, TypeFamilies #-}







src\DateMatcher.hs:49:1: Warning: Eta reduce

Found


dateRange a b c
  = cDateRange (fmap unsafeToCalendarTime a)
      (fmap unsafeToCalendarTime b)
      c

Why not


dateRange a b
  = cDateRange (fmap unsafeToCalendarTime a)
      (fmap unsafeToCalendarTime b)






src\DateMatcher.hs:54:1: Warning: Eta reduce

Found


cDateRange a b c
  = within (fmap toClockTime a) (fmap toClockTime b) (toClockTime c)

Why not


cDateRange a b
  = within (fmap toClockTime a) (fmap toClockTime b) . toClockTime






src\DateTester.hs:46:1: Warning: Eta reduce

Found


testDateAt iso d = testDateAtCal (readUTCDate iso) d

Why not


testDateAt = testDateAtCal . readUTCDate






src\DateTester.hs:50:1: Warning: Use >>=

Found


do ms <- getMatchers d
   putStr . unlines . map (showMatcher c) $ ms

Why not


getMatchers d >>= (putStr . unlines . map (showMatcher c))






src\DateTester.hs:62:6: Error: Redundant $

Found


"\n" ++ (show $ m x now)

Why not


"\n" ++ show (m x now)






src\Exec.hs:19:1: Error: Use better pragmas

Found


{-# OPTIONS_GHC -fglasgow-exts  #-}


Why not


{-# LANGUAGE UnliftedFFITypes, GADTs, ImplicitParams,
  ScopedTypeVariables, UnboxedTuples, TypeSynonymInstances,
  StandaloneDeriving, DeriveDataTypeable, FlexibleContexts,
  FlexibleInstances, ConstrainedClassMethods, MultiParamTypeClasses,
  FunctionalDependencies, MagicHash, PolymorphicComponents,
  ExistentialQuantification, UnicodeSyntax, PostfixOperators,
  PatternGuards, LiberalTypeSynonyms, RankNTypes, ImpredicativeTypes,
  TypeOperators, RecursiveDo, ParallelListComp, EmptyDataDecls,
  KindSignatures, GeneralizedNewtypeDeriving, TypeFamilies #-}







src\Exec.hs:20:1: Error: Unused LANGUAGE pragma

Found


{-# LANGUAGE CPP, ForeignFunctionInterface #-}

Why not


{-# LANGUAGE CPP #-}






src\Exec.hs:32:1: Error: Use fewer imports

Found


import Control.Exception (bracket)
import Control.Exception (bracketOnError)


Why not


import Control.Exception (bracket, bracketOnError)







src\Exec.hs:35:1: Error: Use fewer imports

Found


import System.IO (stdin)
import System.IO (IOMode(..), openBinaryFile, stdout)


Why not


import System.IO (stdin, IOMode(..), openBinaryFile, stdout)







src\Exec.hs:90:1: Warning: Use camelCase

Found


_dev_null = ...

Why not


_devNull = ...






src\Exec.hs:99:1: Warning: Redundant brackets

Found


bracketOnError
  (do whenDebugMode $
        putStrLn $
          unwords $ cmd : args ++ ["; #"] ++ map show [inp, out, err]
      runProcess cmd args Nothing Nothing h_stdin h_stdout h_stderr)
  (terminateProcess)
  (waitForProcess)

Why not


bracketOnError
  (do whenDebugMode $
        putStrLn $
          unwords $ cmd : args ++ ["; #"] ++ map show [inp, out, err]
      runProcess cmd args Nothing Nothing h_stdin h_stdout h_stderr)
  (terminateProcess)
  waitForProcess






src\Exec.hs:99:1: Warning: Redundant brackets

Found


bracketOnError
  (do whenDebugMode $
        putStrLn $
          unwords $ cmd : args ++ ["; #"] ++ map show [inp, out, err]
      runProcess cmd args Nothing Nothing h_stdin h_stdout h_stderr)
  (terminateProcess)

Why not


bracketOnError
  (do whenDebugMode $
        putStrLn $
          unwords $ cmd : args ++ ["; #"] ++ map show [inp, out, err]
      runProcess cmd args Nothing Nothing h_stdin h_stdout h_stderr)
  terminateProcess






src\Exec.hs:127:1: Warning: Use camelCase

Found


exec_interactive cmd arg = ...

Why not


execInteractive cmd arg = ...






src\Exec.hs:134:7: Error: Redundant do

Found


do case oldval of
       Nothing -> unsetEnv var
       Just val -> setEnv var val True

Why not


case oldval of
    Nothing -> unsetEnv var
    Just val -> setEnv var val True






src\Exec.hs:156:1: Error: Redundant do

Found


do setFdOption stdInput NonBlockingRead False

Why not


setFdOption stdInput NonBlockingRead False






src\Exec.hs:156:1: Error: Redundant do

Found


do x

Why not


x






src\Exec.hs:162:22: Warning: Use const

Found


\ _ -> x

Why not


const x






src\HTTP.hs:1:1: Error: Use better pragmas

Found


{-# OPTIONS_GHC -cpp  #-}


Why not








src\HTTP.hs:104:1: Warning: Use camelCase

Found


request_url _ _ _ = ...

Why not


requestUrl _ _ _ = ...






src\HTTP.hs:105:1: Warning: Use camelCase

Found


wait_next_url = ...

Why not


waitNextUrl = ...






src\IsoDate.hs:75:1: Error: Use all

Found


and (map isDigit $ take 14 d)

Why not


all isDigit (take 14 d)






src\IsoDate.hs:144:1: Warning: Use camelCase

Found


date_time tz = ...

Why not


dateTime tz = ...






src\IsoDate.hs:153:1: Warning: Use camelCase

Found


cvs_date_time tz = ...

Why not


cvsDateTime tz = ...






src\IsoDate.hs:172:1: Warning: Use camelCase

Found


old_date_time = ...

Why not


oldDateTime = ...






src\IsoDate.hs:216:1: Warning: Use camelCase

Found


iso8601_date_time localTz = ...

Why not


iso8601DateTime localTz = ...






src\IsoDate.hs:230:1: Warning: Use camelCase

Found


iso8601_date = ...

Why not


iso8601Date = ...






src\IsoDate.hs:278:1: Warning: Use camelCase

Found


iso8601_time = ...

Why not


iso8601Time = ...






src\IsoDate.hs:296:25: Warning: Redundant brackets

Found


10 ^ (picoExp - digsExp) * (read digs)

Why not


10 ^ (picoExp - digsExp) * read digs






src\IsoDate.hs:297:26: Error: Redundant $

Found


Just $ frac

Why not


Just frac






src\IsoDate.hs:299:22: Error: Redundant do

Found


do char '+' >> return 1

Why not


char '+' >> return 1






src\IsoDate.hs:299:22: Error: Redundant do

Found


do char '-' >> return (- 1)

Why not


char '-' >> return (- 1)






src\IsoDate.hs:316:1: Warning: Use camelCase

Found


iso8601_interval localTz = ...

Why not


iso8601Interval localTz = ...






src\IsoDate.hs:342:1: Warning: Use camelCase

Found


iso8601_duration = ...

Why not


iso8601Duration = ...






src\IsoDate.hs:355:23: Warning: Redundant brackets

Found


if (unset x) then 0 else x

Why not


if unset x then 0 else x






src\IsoDate.hs:386:1: Warning: Use camelCase

Found


n_digits n = ...

Why not


nDigits n = ...






src\IsoDate.hs:389:1: Warning: Use camelCase

Found


two_digits = ...

Why not


twoDigits = ...






src\IsoDate.hs:390:1: Warning: Use camelCase

Found


four_digits = ...

Why not


fourDigits = ...






src\IsoDate.hs:396:1: Warning: Use camelCase

Found


my_spaces = ...

Why not


mySpaces = ...






src\IsoDate.hs:400:1: Warning: Use camelCase

Found


day_name = ...

Why not


dayName = ...






src\IsoDate.hs:416:1: Error: Redundant $

Found


intToMonth $ (read mn :: Int)

Why not


intToMonth (read mn :: Int)






src\IsoDate.hs:416:1: Warning: Use camelCase

Found


month_num = ...

Why not


monthNum = ...






src\IsoDate.hs:437:1: Warning: Use camelCase

Found


month_name = ...

Why not


monthName = ...






src\IsoDate.hs:481:1: Warning: Use string literal

Found


[' ']

Why not


" "






src\IsoDate.hs:523:4: Error: Redundant $

Found


fromMaybe id t $ ed

Why not


fromMaybe id t ed






src\IsoDate.hs:529:4: Error: Redundant $

Found


unsetTime $ ed

Why not


unsetTime ed






src\IsoDate.hs:548:1: Error: Redundant $

Found


caseString "today" >> (return $ resetCalendar now)

Why not


caseString "today" >> return (resetCalendar now)






src\IsoDate.hs:548:1: Error: Redundant $

Found


caseString "yesterday" >> (return $ oneDay `subtractFromCal` now)

Why not


caseString "yesterday" >> return (oneDay `subtractFromCal` now)






src\IsoDate.hs:565:1: Error: Redundant do

Found


do space

Why not


space






src\IsoDate.hs:568:20: Error: Redundant $

Found


(try $ caseString "ago" >> return ((- 1), now)) <|>
  do m <- beforeMod <|> afterMod
     space
     d <- englishDate now <|> fst `fmap` englishLast now <|>
            unsafeToCalendarTime `fmap` iso8601_date_time (ctTZ now)
     return (m, d)

Why not


try (caseString "ago" >> return ((- 1), now)) <|>
  do m <- beforeMod <|> afterMod
     space
     d <- englishDate now <|> fst `fmap` englishLast now <|>
            unsafeToCalendarTime `fmap` iso8601_date_time (ctTZ now)
     return (m, d)






src\IsoDate.hs:594:4: Warning: Redundant brackets

Found


(unsafeToCalendarTime `fmap` iso8601_date_time (ctTZ now) <|>
   englishDateTime now)

Why not


unsafeToCalendarTime `fmap` iso8601_date_time (ctTZ now) <|>
  englishDateTime now






src\IsoDate.hs:673:3: Error: Redundant $

Found


caseString "score" >> (return $ TimeDiff 20 0 0 0 0 0 0)

Why not


caseString "score" >> return (TimeDiff 20 0 0 0 0 0 0)






src\IsoDate.hs:673:3: Error: Redundant $

Found


caseString "year" >> (return $ TimeDiff 1 0 0 0 0 0 0)

Why not


caseString "year" >> return (TimeDiff 1 0 0 0 0 0 0)






src\IsoDate.hs:673:3: Error: Redundant $

Found


caseString "month" >> (return $ TimeDiff 0 1 0 0 0 0 0)

Why not


caseString "month" >> return (TimeDiff 0 1 0 0 0 0 0)






src\IsoDate.hs:673:3: Error: Redundant $

Found


caseString "fortnight" >> (return $ TimeDiff 0 0 14 0 0 0 0)

Why not


caseString "fortnight" >> return (TimeDiff 0 0 14 0 0 0 0)






src\IsoDate.hs:673:3: Error: Redundant $

Found


caseString "week" >> (return $ TimeDiff 0 0 7 0 0 0 0)

Why not


caseString "week" >> return (TimeDiff 0 0 7 0 0 0 0)






src\IsoDate.hs:673:3: Error: Redundant $

Found


caseString "day" >> (return $ TimeDiff 0 0 1 0 0 0 0)

Why not


caseString "day" >> return (TimeDiff 0 0 1 0 0 0 0)






src\IsoDate.hs:673:3: Error: Redundant $

Found


caseString "hour" >> (return $ TimeDiff 0 0 0 1 0 0 0)

Why not


caseString "hour" >> return (TimeDiff 0 0 0 1 0 0 0)






src\IsoDate.hs:673:3: Error: Redundant $

Found


caseString "minute" >> (return $ TimeDiff 0 0 0 0 1 0 0)

Why not


caseString "minute" >> return (TimeDiff 0 0 0 0 1 0 0)






src\IsoDate.hs:673:3: Error: Redundant $

Found


caseString "second" >> (return $ TimeDiff 0 0 0 0 0 1 0)

Why not


caseString "second" >> return (TimeDiff 0 0 0 0 0 1 0)






src\IsoDate.hs:768:1: Warning: Redundant brackets

Found


a7 * (toInteger m)

Why not


a7 * toInteger m






src\Lcs.hs:19:1: Error: Use better pragmas

Found


{-# OPTIONS_GHC -cpp  #-}


Why not








src\Lcs.hs:79:3: Warning: Redundant brackets

Found


off > (aLen a)

Why not


off > aLen a






src\Lcs.hs:80:3: Warning: Redundant brackets

Found


off > (aLen b)

Why not


off > aLen b






src\Lcs.hs:97:3: Warning: Redundant brackets

Found


(a ! (from)) : (getSlice a (from + 1) to)

Why not


(a ! (from)) : getSlice a (from + 1) to






src\Lcs.hs:97:3: Warning: Redundant brackets

Found


a ! (from)

Why not


a ! from






src\Lcs.hs:109:17: Error: Use /=

Found


not (new == old)

Why not


new /= old






src\Lcs.hs:118:17: Error: Use /=

Found


not (new == old)

Why not


new /= old






src\Lcs.hs:134:9: Error: Use mapMaybe

Found


catMaybes $ map get [(i, ah ! i) | i <- range (bounds ah)]

Why not


mapMaybe get [(i, ah ! i) | i <- range (bounds ah)]






src\Lcs.hs:135:9: Error: Use mapMaybe

Found


catMaybes $ map get [(i, bh ! i) | i <- range (bounds bh)]

Why not


mapMaybe get [(i, bh ! i) | i <- range (bounds bh)]






src\Lcs.hs:147:1: Error: Redundant $

Found


mapM_ (\ (l, _) -> writeArray c_a l False) $ a

Why not


mapM_ (\ (l, _) -> writeArray c_a l False) a






src\Lcs.hs:147:1: Error: Redundant $

Found


mapM_ (\ (l, _) -> writeArray c_b l False) $ b

Why not


mapM_ (\ (l, _) -> writeArray c_b l False) b






src\Lcs.hs:147:1: Warning: Redundant brackets

Found


when (err)

Why not


when err






src\Lcs.hs:147:1: Error: Redundant $

Found


mapM_ (\ i -> writeArray c_a i False) $ [1 .. (off_a - 1)]

Why not


mapM_ (\ i -> writeArray c_a i False) [1 .. (off_a - 1)]






src\Lcs.hs:147:1: Error: Redundant $

Found


mapM_ (\ i -> writeArray c_b i False) $ [1 .. (off_b - 1)]

Why not


mapM_ (\ i -> writeArray c_b i False) [1 .. (off_b - 1)]






src\Lcs.hs:147:1: Error: Redundant $

Found


mapM_ (\ i -> writeArray c_a i False) $ [(l_a + 1) .. (end_a)]

Why not


mapM_ (\ i -> writeArray c_a i False) [(l_a + 1) .. (end_a)]






src\Lcs.hs:147:1: Warning: Redundant brackets

Found


[(l_a + 1) .. (end_a)]

Why not


[(l_a + 1) .. end_a]






src\Lcs.hs:147:1: Error: Redundant $

Found


mapM_ (\ i -> writeArray c_b i False) $ [(l_b + 1) .. (end_b)]

Why not


mapM_ (\ i -> writeArray c_b i False) [(l_b + 1) .. (end_b)]






src\Lcs.hs:147:1: Warning: Redundant brackets

Found


[(l_b + 1) .. (end_b)]

Why not


[(l_b + 1) .. end_b]






src\Lcs.hs:147:1: Warning: Redundant brackets

Found


when (err1)

Why not


when err1






src\Lcs.hs:159:10: Error: Redundant $

Found


(length $ filter not $ xs) - 1

Why not


length (filter not $ xs) - 1






src\Lcs.hs:159:10: Error: Redundant $

Found


filter not $ xs

Why not


filter not xs






src\Lcs.hs:178:1: Error: Redundant do

Found


do return 0

Why not


return 0






src\Lcs.hs:200:18: Error: Redundant $

Found


odd $ del

Why not


odd del






src\Lcs.hs:222:1: Error: Use when

Found


if c > l_a + l_b then error "findDiag failed" else return ()

Why not


when (c > l_a + l_b) $ error "findDiag failed"






src\Lcs.hs:235:8: Warning: Redundant brackets

Found


l_b - ((l_b + (c - 1) `mod` 2))

Why not


l_b - (l_b + (c - 1) `mod` 2)






src\Lcs.hs:313:8: Warning: Redundant brackets

Found


(aLen p_a) + 1

Why not


aLen p_a + 1






src\Lcs.hs:329:8: Error: Redundant do

Found


do return (start, i, j)

Why not


return (start, i, j)






src\Lcs.hs:329:8: Warning: Redundant brackets

Found


(not b1) || b2

Why not


not b1 || b2






src\Lcs.hs:344:8: Error: Redundant do

Found


do return (start, i, j, corr, blank)

Why not


return (start, i, j, corr, blank)






src\Lcs.hs:344:8: Warning: Redundant brackets

Found


(not b2) || b1

Why not


not b2 || b1






src\Lcs.hs:363:8: Warning: Redundant brackets

Found


(not b1) || b2

Why not


not b1 || b2






src\Lcs.hs:397:1: Warning: Use >>=

Found


do i' <- skipOneUnChanged c i
   nextUnchangedN c (n - 1) i'

Why not


skipOneUnChanged c i >>= nextUnchangedN c (n - 1)






src\Lcs.hs:397:1: Error: Redundant do

Found


do if n == 0 then return i else
     do i' <- skipOneUnChanged c i
        nextUnchangedN c (n - 1) i'

Why not


if n == 0 then return i else
  do i' <- skipOneUnChanged c i
     nextUnchangedN c (n - 1) i'






src\Lcs.hs:427:1: Error: Redundant do

Found


do newArray (- (dmax + 1), dmax + 1) (- 1)

Why not


newArray (- (dmax + 1), dmax + 1) (- 1)






src\Lcs.hs:431:1: Error: Redundant do

Found


do newArray (- (dmax + 1), dmax + 1) (xmax + 1)

Why not


newArray (- (dmax + 1), dmax + 1) (xmax + 1)






src\Lcs.hs:459:1: Warning: Eta reduce

Found


aLen a = snd $ bounds a

Why not


aLen = snd . bounds






src\Lcs.hs:474:3: Warning: Redundant brackets

Found


(b ! (from + 1)) : (getInsert b (from + 1) to)

Why not


(b ! (from + 1)) : getInsert b (from + 1) to






src\Lcs.hs:478:3: Warning: Redundant brackets

Found


(a ! (from + 1)) : (getDelete a (from + 1) to)

Why not


(a ! (from + 1)) : getDelete a (from + 1) to






src\Lcs.hs:486:1: Warning: Redundant brackets

Found


(ia', ia, ib', ib) : (createP c_a c_b ia' ib')

Why not


(ia', ia, ib', ib) : createP c_a c_b ia' ib'






src\list_authors.hs:30:1: Warning: Redundant brackets

Found


if do_stats then "" else
  ("Run " ++
     formatPath (prog_name ++ " stats") ++
       " for more detailed information.\n" ++ "\n")

Why not


if do_stats then "" else
  "Run " ++
    formatPath (prog_name ++ " stats") ++
      " for more detailed information.\n" ++ "\n"






src\list_authors.hs:60:1: Warning: Use camelCase

Found


marnix_klooster = ...

Why not


marnixKlooster = ...






src\list_authors.hs:61:1: Warning: Use camelCase

Found


eric_kow = ...

Why not


ericKow = ...






src\list_authors.hs:62:1: Warning: Use camelCase

Found


andres_loeh = ...

Why not


andresLoeh = ...






src\list_authors.hs:63:1: Warning: Use camelCase

Found


simon_marlow = ...

Why not


simonMarlow = ...






src\list_authors.hs:64:1: Warning: Use camelCase

Found


erik_schnetter = ...

Why not


erikSchnetter = ...






src\list_authors.hs:65:1: Warning: Use camelCase

Found


gwern_branwen = ...

Why not


gwernBranwen = ...






src\list_authors.hs:66:1: Warning: Use camelCase

Found


pekka_pessi = ...

Why not


pekkaPessi = ...






src\list_authors.hs:67:1: Warning: Use camelCase

Found


mark_stosberg = ...

Why not


markStosberg = ...






src\list_authors.hs:68:1: Warning: Use camelCase

Found


edwin_thomson = ...

Why not


edwinThomson = ...






src\list_authors.hs:69:1: Warning: Use camelCase

Found


thomas_zander = ...

Why not


thomasZander = ...






src\list_authors.hs:70:1: Warning: Use camelCase

Found


tomasz_zielonka = ...

Why not


tomaszZielonka = ...






src\list_authors.hs:71:1: Warning: Use camelCase

Found


lele_gaifax = ...

Why not


leleGaifax = ...






src\list_authors.hs:72:1: Warning: Use camelCase

Found


christian_kellermann = ...

Why not


christianKellermann = ...






src\list_authors.hs:79:1: Warning: Use camelCase

Found


authors_sans_name = ...

Why not


authorsSansName = ...






src\list_authors.hs:147:1: Warning: Use camelCase

Found


canonize_author "David" = ...

Why not


canonizeAuthor "David" = ...






src\list_authors.hs:190:1: Warning: Redundant brackets

Found


(uncurry add_name_to_mail) $ head eaLst

Why not


uncurry add_name_to_mail $ head eaLst






src\list_authors.hs:197:1: Warning: Use &&&

Found


\ s -> (length s, head s)

Why not


length &&& head






src\list_authors.hs:197:1: Warning: Use camelCase

Found


sort_authors use_stats as = ...

Why not


sortAuthors use_stats as = ...






src\list_authors.hs:210:1: Warning: Use camelCase

Found


add_name_to_mail m n = ...

Why not


addNameToMail m n = ...






src\microbench.hs:38:44: Error: Use print

Found


putStrLn (show e)

Why not


print e






src\OldDate.hs:42:1: Error: Use all

Found


and (map isDigit $ take 14 d)

Why not


all isDigit (take 14 d)






src\OldDate.hs:104:1: Warning: Use camelCase

Found


date_time tz = ...

Why not


dateTime tz = ...






src\OldDate.hs:110:1: Warning: Use camelCase

Found


cvs_date_time tz = ...

Why not


cvsDateTime tz = ...






src\OldDate.hs:126:1: Warning: Use camelCase

Found


old_date_time = ...

Why not


oldDateTime = ...






src\OldDate.hs:161:1: Warning: Use camelCase

Found


iso8601_date_time localTz = ...

Why not


iso8601DateTime localTz = ...






src\OldDate.hs:168:1: Warning: Use camelCase

Found


iso8601_date = ...

Why not


iso8601Date = ...






src\OldDate.hs:193:20: Warning: Redundant brackets

Found


(7 * w) + wd - (fromEnum firstDay)

Why not


(7 * w) + wd - fromEnum firstDay






src\OldDate.hs:212:1: Warning: Use camelCase

Found


iso8601_time = ...

Why not


iso8601Time = ...






src\OldDate.hs:230:25: Warning: Redundant brackets

Found


10 ^ (picoExp - digsExp) * (read digs)

Why not


10 ^ (picoExp - digsExp) * read digs






src\OldDate.hs:233:22: Error: Redundant do

Found


do char '+' >> return 1

Why not


char '+' >> return 1






src\OldDate.hs:233:22: Error: Redundant do

Found


do char '-' >> return (- 1)

Why not


char '-' >> return (- 1)






src\OldDate.hs:249:1: Warning: Use camelCase

Found


n_digits n = ...

Why not


nDigits n = ...






src\OldDate.hs:252:1: Warning: Use camelCase

Found


two_digits = ...

Why not


twoDigits = ...






src\OldDate.hs:253:1: Warning: Use camelCase

Found


four_digits = ...

Why not


fourDigits = ...






src\OldDate.hs:256:1: Warning: Use camelCase

Found


my_spaces = ...

Why not


mySpaces = ...






src\OldDate.hs:259:1: Warning: Use camelCase

Found


day_name = ...

Why not


dayName = ...






src\OldDate.hs:273:1: Error: Redundant $

Found


intToMonth $ (read mn :: Int)

Why not


intToMonth (read mn :: Int)






src\OldDate.hs:273:1: Warning: Use camelCase

Found


month_num = ...

Why not


monthNum = ...






src\OldDate.hs:292:1: Warning: Use camelCase

Found


month_name = ...

Why not


monthName = ...






src\OldDate.hs:321:1: Warning: Use string literal

Found


[' ']

Why not


" "






src\preproc.hs:17:1: Warning: Use camelCase

Found


the_commands = ...

Why not


theCommands = ...






src\preproc.hs:20:1: Error: Use when

Found


if length args < 1 then exitWith $ ExitFailure 1 else return ()

Why not


when (length args < 1) $ exitWith $ ExitFailure 1






src\preproc.hs:30:1: Warning: Use camelCase

Found


am_html = ...

Why not


amHtml = ...






src\preproc.hs:86:1: Warning: Use camelCase

Found


get_options comm = ...

Why not


getOptions comm = ...






src\preproc.hs:90:1: Warning: Use camelCase

Found


get_c (name : ns) commands = ...

Why not


getC (name : ns) commands = ...






src\preproc.hs:94:10: Error: Redundant $

Found


c : (get_c ns $ extract_commands $ command_sub_commands c)

Why not


c : get_c ns (extract_commands $ command_sub_commands c)






src\preproc.hs:104:1: Warning: Use camelCase

Found


get_com_options c = ...

Why not


getComOptions c = ...






src\preproc.hs:120:1: Warning: Use camelCase

Found


command_property property commands name = ...

Why not


commandProperty property commands name = ...






src\Progress.hs:3:1: Error: Use better pragmas

Found


{-# OPTIONS_GHC -cpp  #-}


Why not








src\Progress.hs:90:1: Warning: Redundant brackets

Found


"Beginning " ++ (map toLower k)

Why not


"Beginning " ++ map toLower k






src\Progress.hs:90:1: Error: Redundant $

Found


setProgressData k $
  ProgressData{sofar = 0, latest = Nothing, total = Nothing}

Why not


setProgressData k
  ProgressData{sofar = 0, latest = Nothing, total = Nothing}






src\Progress.hs:98:1: Warning: Use second

Found


\ (a, m) -> (a, delete k m)

Why not


second (delete k)






src\Progress.hs:98:1: Warning: Redundant brackets

Found


"Done " ++ (map toLower k)

Why not


"Done " ++ map toLower k






src\Progress.hs:171:28: Error: Use putStr

Found


hPutStr stdout

Why not


putStr






src\Progress.hs:176:28: Error: Use unless

Found


when (not $ null s)

Why not


unless (null s)






src\Progress.hs:180:1: Warning: Eta reduce

Found


setProgressMode m = writeIORef _progressMode m

Why not


setProgressMode = writeIORef _progressMode






src\Progress.hs:195:1: Warning: Use second

Found


\ (a, m) -> (a, insert k p m)

Why not


second (insert k p)






src\RegChars.hs:50:22: Warning: Use const

Found


\ _ -> False

Why not


const False






src\SHA1.hs:53:1: Warning: Use camelCase

Found


fiddle_endianness p 0 = ...

Why not


fiddleEndianness p 0 = ...






src\SHA1.hs:69:1: Warning: Use camelCase

Found


sha1_step_1_2_pad_length s = ...

Why not


sha1Step12PadLength s = ...






src\SHA1.hs:77:1: Warning: Use camelCase

Found


size_split 0 _ = ...

Why not


sizeSplit 0 _ = ...






src\SHA1.hs:82:1: Warning: Use camelCase

Found


sha1_step_3_init = ...

Why not


sha1Step3Init = ...






src\SHA1.hs:85:1: Warning: Use camelCase

Found


sha1_step_4_main abcde _ 0 = ...

Why not


sha1Step4Main abcde _ 0 = ...






src\SHA1.hs:171:8: Warning: Redundant brackets

Found


(complement x) .&. z

Why not


complement x .&. z






src\SHA1.hs:194:1: Warning: Use camelCase

Found


sha1_step_5_display (ABCDE a b c d e) = ...

Why not


sha1Step5Display (ABCDE a b c d e) = ...






src\Ssh.hs:1:1: Error: Unused LANGUAGE pragma

Found


{-# LANGUAGE CPP, ForeignFunctionInterface #-}

Why not


{-# LANGUAGE CPP #-}






src\Ssh.hs:62:18: Error: Use unless

Found


if l == "Hello user, I am darcs transfer mode" then return () else
  debugFail "Couldn't start darcs transfer-mode on server"

Why not


unless (l == "Hello user, I am darcs transfer mode") $
  debugFail "Couldn't start darcs transfer-mode on server"






src\Ssh.hs:75:30: Error: Redundant $

Found


unlines $
  ["NOTE: the server may be running a version of darcs prior to 2.0.0.",
   "",
   "Installing darcs 2 on the server will speed up ssh-based commands."]

Why not


unlines
  ["NOTE: the server may be running a version of darcs prior to 2.0.0.",
   "",
   "Installing darcs 2 on the server will speed up ssh-based commands."]






src\Ssh.hs:105:20: Warning: Redundant brackets

Found


((\ imp_funny_name ->
    imp_funny_name
      ("src\\\\\\\\Ssh.hs", 96, "17:12:52", "29 Aug 2009"))
   (Bug_._bug HTTP_.fetchUrl))
  $ "Buggy path in grabSSH: " ++ x

Why not


(\ imp_funny_name ->
   imp_funny_name
     ("src\\\\\\\\Ssh.hs", 96, "17:12:52", "29 Aug 2009"))
  (Bug_._bug HTTP_.fetchUrl)
  $ "Buggy path in grabSSH: " ++ x






src\Ssh.hs:154:10: Error: Redundant $

Found


cd ++ (unlines $ map ("get " ++) ns)

Why not


cd ++ unlines (map ("get " ++) ns)






src\Ssh.hs:161:17: Warning: Redundant brackets

Found


(take 5 ns) ++ ["and " ++ (show (length ns - 5)) ++ " more"]

Why not


take 5 ns ++ ["and " ++ (show (length ns - 5)) ++ " more"]






src\Ssh.hs:161:17: Warning: Redundant brackets

Found


(show (length ns - 5)) ++ " more"

Why not


show (length ns - 5) ++ " more"






src\Ssh.hs:165:17: Warning: Use list comprehension

Found


if take 1 path == "~" then
  ["sftp doesn't expand ~, use path/ instead of ~/path/"] else []

Why not


["sftp doesn't expand ~, use path/ instead of ~/path/" |
 take 1 path == "~"]






src\Ssh.hs:165:17: Error: Use isPrefixOf

Found


take 1 path == "~"

Why not


"~" `isPrefixOf` path






src\Ssh.hs:200:13: Error: Use unless

Found


when (not hasLaunchedCm)

Why not


unless hasLaunchedCm






src\Ssh.hs:200:13: Warning: Use list comprehension

Found


if hasCmFeature then ["-o ControlPath=" ++ cmPath] else []

Why not


["-o ControlPath=" ++ cmPath | hasCmFeature]






src\Ssh.hs:284:7: Error: Redundant $

Found


(fmap (/// ".darcs") $ getEnv "HOME") `catchall` tempdir_loc

Why not


fmap (/// ".darcs") (getEnv "HOME") `catchall` tempdir_loc






src\URL.hs:1:1: Error: Unused LANGUAGE pragma

Found


{-# LANGUAGE CPP, ForeignFunctionInterface #-}

Why not


{-# LANGUAGE CPP #-}






src\URL.hs:105:1: Error: Redundant $

Found


newIORef $ 1

Why not


newIORef 1






src\URL.hs:181:15: Warning: Redundant brackets

Found


return . (Map.lookup u)

Why not


return . Map.lookup u






src\URL.hs:208:11: Warning: Redundant brackets

Found


((\ imp_funny_name ->
    imp_funny_name
      ("src\\\\\\\\URL.hs", 199, "17:12:52", "29 Aug 2009"))
   (Bug_._bug HTTP_.fetchUrl))
  $ "Possible bug in URL.checkWaitToStart " ++ u

Why not


(\ imp_funny_name ->
   imp_funny_name
     ("src\\\\\\\\URL.hs", 199, "17:12:52", "29 Aug 2009"))
  (Bug_._bug HTTP_.fetchUrl)
  $ "Possible bug in URL.checkWaitToStart " ++ u






src\URL.hs:219:1: Warning: Redundant brackets

Found


return . (Map.insertWith fn u v)

Why not


return . Map.insertWith fn u v






src\URL.hs:234:24: Error: Redundant $

Found


liftIO $ wait_next_url

Why not


liftIO wait_next_url






src\URL.hs:245:33: Warning: Redundant brackets

Found


((\ imp_funny_name ->
    imp_funny_name
      ("src\\\\\\\\URL.hs", 236, "17:12:52", "29 Aug 2009"))
   (Bug_._bug HTTP_.fetchUrl))
  $ "Possible bug in URL.waitNextUrl: " ++ u

Why not


(\ imp_funny_name ->
   imp_funny_name
     ("src\\\\\\\\URL.hs", 236, "17:12:52", "29 Aug 2009"))
  (Bug_._bug HTTP_.fetchUrl)
  $ "Possible bug in URL.waitNextUrl: " ++ u






src\URL.hs:252:33: Warning: Redundant brackets

Found


((\ imp_funny_name ->
    imp_funny_name
      ("src\\\\\\\\URL.hs", 243, "17:12:52", "29 Aug 2009"))
   (Bug_._bug HTTP_.fetchUrl))
  $ "Another possible bug in URL.waitNextUrl: " ++ u ++ " " ++ e

Why not


(\ imp_funny_name ->
   imp_funny_name
     ("src\\\\\\\\URL.hs", 243, "17:12:52", "29 Aug 2009"))
  (Bug_._bug HTTP_.fetchUrl)
  $ "Another possible bug in URL.waitNextUrl: " ++ u ++ " " ++ e






src\URL.hs:260:18: Warning: Redundant brackets

Found


return . (Map.lookup u)

Why not


return . Map.lookup u






src\URL.hs:262:18: Warning: Redundant brackets

Found


return . (Map.delete u)

Why not


return . Map.delete u






src\URL.hs:288:1: Error: Redundant $

Found


writeIORef maxPipeLength 1 >>
  (putStrLn $
     "Warning: darcs is compiled without HTTP pipelining " ++
       "support, '--http-pipelining' argument is ignored.")

Why not


writeIORef maxPipeLength 1 >>
  putStrLn
    ("Warning: darcs is compiled without HTTP pipelining " ++
       "support, '--http-pipelining' argument is ignored.")






src\URL.hs:363:1: Warning: Use camelCase

Found


request_url _ _ _ = ...

Why not


requestUrl _ _ _ = ...






src\URL.hs:364:1: Warning: Use camelCase

Found


wait_next_url = ...

Why not


waitNextUrl = ...






src\Workaround.hs:1:1: Error: Use better pragmas

Found


{-# OPTIONS_GHC -cpp  #-}


Why not